On Wed, Jan 07, 2015 at 09:11:06AM +0000, Wookey wrote:
+++ Stacho Mudrak [2014-12-30 11:09 +0100]:
* 82-nolang-segfault-fix.patch (this avoids a genuine error case of language not being defined)
I believe, this error is already fixed. Are you able to reproduce it with current version of therion?
I can't remember what the issue was or how to reproduce it. Anyone remember?
No, but thlang_getid() now starts with an explicit check to handle the case where the id is -1, so the patch is clearly no longer needed: const char * thlang_getid(int id) { if (id < 0) { return "en"; } In 5.3.11 (which the patch was created from judging by the paths), this check isn't present, though it looks to me like thlang_getlang() will map -1 (which is THLANG_UNKNOWN) to something valid, so it looks to me like it wasn't actually useful even there. Perhaps the patch is actually older and was just regenerated for 5.3.11, but debian/changelog doesn't seem to actually mention it being added, and the packaging isn't kept in a VCS, so it's harder to check than I can be bothered to. The important conclusion is that it clearly isn't useful for 5.3.16. Cheers, Olly