[Therion] Scrap flip horizontal breaks join line point functionality bug

[Bruce Mutton]

I have a bug, whereby manual joining of line points will fail (ie manual as
described here
https://therion.speleo.sk/wiki/tips?s[]=join#joining_scraps_together
<https://therion.speleo.sk/wiki/tips?s%5b%5d=join#joining_scraps_together> )

The trigger is when one of the scraps has -flip horizontal set and the other
does not.  I have not tested flip vertical.

Seems to occur whether :0, :end, :<point number> or :mark syntax is used.

 

As an example, for extended elevation where the yellow scrap (s8) is drawn
so that -flip = none, and the blue scrap (s3) is drawn so that -flip =
horizontal

With no joins in effect:



 

Syntax used:

join 3-s8topstring at Hawkes:0 3-s3topstring at Hawkes:end



It looks like I have joined the wrong end of one of the lines, but I have
not.

 

But there is a workaround that is sometimes successful - specify the
opposite end of the line in the flipped scrap, to that which you want.

join 3-s8topstring at Hawkes:0 3-s3topstring at Hawkes:0



The above example has properly joined both the scraps (semi-automatic join
of s8 and s3) and joined both the red lines using manual joins where the
'opposite end' of the lines in the flipped scrap has been specified.  So I
have made it work out OK in this example, but is a nasty workaround.

 

I have tried defining marks for the points that I want to join, but this bug
persists even if you define custom marks.

 

Joining scraps is not affected though, join scrapflipnone scrapfliphorz will
work just fine.

In the example above,   join 3-HawkesElevEXT-s8 at Hawkes
3-HawkesElevEXT-s3 at Hawkes produces a perfect join for the scrap walls, but
as expected not of the internal lines.

 

My hypothesis:

When it comes to joining line points, the point numbering and point mark
association is messed up (reversed?) when (at least?) one of the scraps has
-flip horizontal set.

 

Bruce

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20221031/7df280a9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image005.png
Type: image/png
Size: 143931 bytes
Desc: not available
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20221031/7df280a9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image006.png
Type: image/png
Size: 137189 bytes
Desc: not available
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20221031/7df280a9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image008.png
Type: image/png
Size: 154959 bytes
Desc: not available
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20221031/7df280a9/attachment-0005.png>