[Therion] Display Station comments on Map?

[Bruce Mutton]

Hmm, I have not time to look into this, don't really understand much about metapost at all, but my recollection is that I could get all the features implied in the code of the original p_station to manifest in outputs (at least of centrelines, if not scraps).  If you have removed code, then I suggest others look very carefully before this is committed.
Although looking at your diff, it seem like you have taken little if anything out, so maybe my concern is unfounded?
Bruce

-----Original Message-----
From: Therion <therion-bounces at speleo.sk> On Behalf Of Max D
Sent: Wednesday, 4 September 2019 08:05
To: List for Therion users <therion at speleo.sk>
Subject: Re: [Therion] Display Station comments on Map?



> On 3. Sep 2019, at 14:35, Max D <md at foxel.org> wrote:
> 
> To me it seems that the "flags" parameter in therion 5.4.4+b998d1b (2019-06-12) is always empty.
> Not sure if this is a bug or if I'm missing something. The p_station_SKBB() macro has a lot of code for handling different flags which seems to be unused.
> 

I produced a patch for therion which makes it display all flags for "station" entries. I'm not very firm with MetaPost and Therion internal structures, but it seems to me, the original code simply could not work. OR I just did not understand.

The patch is at.
https://gist.github.com/mdornseif/3b3764844cae2f6274726674a9c68a0f

https://tug.org/pipermail/metapost/2006-February/000527.html helped me to understand what is going on in MetaPost.

--max

_______________________________________________
Therion mailing list
Therion at speleo.sk
https://mailman.speleo.sk/listinfo/therion