[Therion] Therion crashes in shapes.h when generating 3D

[Michael]

Thanks, Bruce, for your efforts and helpful explanations.

The reason for the "scattered" scrap is that it is overlayed upon an older, scanned piece of plan, which I didn't want to completely
redraw. Initially.
I think we can close this thread now, things work again and I learned a lot from you guys.

Cheers, Michael.

-----Ursprüngliche Nachricht-----
Von: Therion [mailto:therion-bounces at speleo.sk] Im Auftrag von Bruce Mutton via Therion
Gesendet: Sonntag, 26. November 2017 21:34
An: 'List for Therion users' <therion at speleo.sk>
Cc: Bruce Mutton <bruce at tomo.co.nz>
Betreff: [Therion] Therion crashes in shapes.h when generating 3D

Michael
After some cosmetic changes to your thconfig I managed to compile.  I also added some georeferencing so I could export kml files.
As per the attached pdf, It looks like your scrap interiors are properly defined, except for the three armed passage near the top
left.

I have not found it written down, but my assumption is that each scrap should be a single contiguous piece of passage.  My
experience is that 'export map' does not produce properly rendered kml files unless you stick to this 'rule'.
The SA9.th2 file you supplied looks like it should be 9 scraps (including the cross-section), one for each contiguous section of
passage drawn. 
The attached model kml looks fine I think, but as expected the map kml has not been able to render.
Refer to
https://therion.speleo.sk/wiki/tips#avoiding_invisible_or_misshapen_scraps_i
n_loch_and_google_earth

When I tried your export model to lox I get the same Windows error that you reported.
With such a chaotic scrap, I would expect unpredictable things to happen.
The lox file generator is trying to use the scrap outlines to determine the model shape, and so I would suggest that if the kml map
is having difficulty, then a model trying to inherit scrap outlines is likely to have even more trouble.

I would suggest either making each distinct piece of drawing a separate scrap, or drawing your scrap progressively from a single
starting point, if you want to create models that are not purely centreline based.

In the attached config file, if you comment out the export model lox line, the attached project files compile without error
(provided you create an output folder first).

If there is a Therion development task here, then it would be to detect these anomalies at the 'export map kml' and 'export
model-using-outlines'
stage and exit gracefully by reporting a warning in the first case, and an error in the second case.

Bruce


-----Original Message-----
From: Therion [mailto:therion-bounces at speleo.sk] On Behalf Of Michael via Therion
Sent: Monday, 27 November 2017 12:42 AM
To: therion at speleo.sk
Cc: Michael <knollesimage at t-online.de>
Subject: [Therion] WG: Therion crashes in shapes.h when generating 3D

Hello,
After tedious search through 100s of Scraps I have now isolated the one
(SA9.th2) scrap which crashes Therion in extern/poly2tri/sweep/../common/shapes.h
It's attached together with an excerpt of the survey data.
Admittingly, the walls are not drawn very well, but after fixing and completing the walls (not done in attached sample) it still
crashes Therion.
May this example be a test case for developers to improve Therion's robustness.
BTW, it also crashes older Therion releases.

Cheers,
Michael.

-----Ursprüngliche Nachricht-----
Von: Michael [mailto:knollesimage at t-online.de]
Gesendet: Samstag, 4. November 2017 14:48
An: 'List for Therion users' <therion at speleo.sk>
Betreff: Therion crashes in shapes.h when generating 3D

Hello,
Seeking advice from Therion developers how to track down the cause of attached crash report, and apply possible workaround.
Only happens when generating 3D of any format.
Producing plans (pdf, kml) works.
I'm running Therion 5.4.1 on Windows 7.
The crash seems unrelated to the last scrap processed before the crash, because when I exclude that scrap, it crashes after approx.
the same time with a different one.

Any help appreciated,
Michael.