[Therion] Line wall AUT crashes and a fix

[Georg Pacher]

On 02.07.2011 11:31, Bruce wrote:
>
> I have been using some of Georg Pacher's very clever (I think) AUT 
> symbols in their standard form, allocated from within a layout with ...
>
>   symbol-assign area debris AUT
>
>   symbol-assign line wall:debris AUT
>
>   symbol-assign point debris AUT
>
> etc
>
> All has been going quite well for sometime, but tonight Therion 5.3.8 
> gets into an endless loop, repeating the following text...
>
> l_wall_debris->...factor:=scale_factor-0.01;endfor
>
>                                                   
> ;thdraw.block.rotated.angl.
>
> l.6513 ))
>
>          ;
>
> ! Value is too large (-4104.55951).
>
> <forever> ...k)<0;scale_factor:=scale_factor-0.01;
>
>                                                    ENDFOR
>
> I tend to use a scale of 1:1000, but this time I was using 1:5000, so 
> I'm guessing that has overloaded one of the functions in the final 
> loop below.  Not sure which variable or function is causing the crash 
> but the value is always the same for any particular scale at each loop 
> cycle.
>
> At these scales the length of each line is often going to be much less 
> than the size of the symbol so I expect we need a more cunning exitif 
> criteria.  I have made a stab at fixing it below (the exitif in grey), 
> but it is probably not the best solution.  It works now however at 
> 1:1000, 1:5000 and 1:10,000.
>
> Someone who knows what they are doing might be able to propose a 
> better fix and Martin/Stacho could include it in the next snapshot.
>
> I am perplexed by two other somewhat unrelated things.
>
> The debris symbols as they turn out in the output are all filled 
> except the first or last one (not sure which) and yet I cannot find a 
> fill command in the code.  Having one not filled gives nice quirky 
> random effect, but they are perhaps better filled?
>
> Line blocks AUT works perfectly, and yet the code seems to have the 
> same general type of loop and test as the line debris AUT that gives 
> this problem.
>
> Cheers, Bruce
>
[...]

Hi!

Thanks for your feedback Bruce, it's good to know that the symbols are 
also used somewhere else, outside of Austria ;-)
When I checked the problems, I found another one in the symbol "line 
wall:pit", so I simply attach the newest version of the Austrian symbol 
set, so Martin can include it.

The changes regard the following symbols:
line wall:pit
line wall:debris
point debris

It includes the fix (as suggested by Martin) for point debris, your fix 
for the scale problem with wall:debris, an additional thclean for the 
'filling' of the first debris in the line and a fix for wall:pit in 
large scales.

Thanks for pointing out these issues,
Georg.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20110717/150eca9c/attachment.htm>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uAUT.mp
URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20110717/150eca9c/attachment.ksh>