"line -close on" unexpected behaviour
Hi, I was trying to understand how Therion deals with "line -close ON|OFF|AUTO" and found an expected behaviour for "line -close on". For the simple file attached (here is a print screen on Mapiah): [image.png] Here is the current result (again, original file attached, here a simple print screen): [image.png] And here is want I expected, the new result with PR #741 (https://github.com/therion/therion/pull/741) produces: [image.png] The patch I created clearly changes the behaviour of Therion but, I believe, it changes to something more sensible. Does this change looks like a issue to someone? Regards, Rodrigo
Does it handle the case where the last point is in the same location as the first one (like when drawing rocks)?
Am 25.03.2026 um 15:36 schrieb Rodrigo Severo via Therion <therion@speleo.sk>:
Hi,
I was trying to understand how Therion deals with "line -close ON|OFF|AUTO" and found an expected behaviour for "line -close on".
For the simple file attached (here is a print screen on Mapiah):
<image.png> Here is the current result (again, original file attached, here a simple print screen): <image.png>
And here is want I expected, the new result with PR #741 (https://github.com/therion/therion/pull/741) produces:
<image.png>
The patch I created clearly changes the behaviour of Therion but, I believe, it changes to something more sensible.
Does this change looks like a issue to someone?
Regards,
Rodrigo
<line_close.zip> <line_close-new.pdf> <line_close-current.pdf> _______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
Yes. In the situation you described, it keeps the previous behaviour: for "-close on" it does nothing. Rodrigo On Wednesday, March 25th, 2026 at 12:06 PM, Benedikt Hallinger via Therion <therion@speleo.sk> wrote:
Does it handle the case where the last point is in the same location as the first one (like when drawing rocks)?
Am 25.03.2026 um 15:36 schrieb Rodrigo Severo via Therion <therion@speleo.sk>:
Hi,
I was trying to understand how Therion deals with "line -close ON|OFF|AUTO" and found an expected behaviour for "line -close on".
For the simple file attached (here is a print screen on Mapiah):
<image.png> Here is the current result (again, original file attached, here a simple print screen): <image.png>
And here is want I expected, the new result with PR #741 (https://github.com/therion/therion/pull/741) produces:
<image.png>
The patch I created clearly changes the behaviour of Therion but, I believe, it changes to something more sensible.
Does this change looks like a issue to someone?
Regards,
Rodrigo
<line_close.zip> <line_close-new.pdf> <line_close-current.pdf>_______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
Thanks, then it would be the behaviour I would expect tbh. So the old behaviour I would consider as bug. But I don‘t recall running into the situation, tbh, because when I need to close, I usually do it like described, and where not, the last Point is at least near the first one. Kind regards! Beni
Am 25.03.2026 um 16:19 schrieb Rodrigo Severo via Therion <therion@speleo.sk>:
Yes. In the situation you described, it keeps the previous behaviour: for "-close on" it does nothing.
Rodrigo
On Wednesday, March 25th, 2026 at 12:06 PM, Benedikt Hallinger via Therion <therion@speleo.sk> wrote: Does it handle the case where the last point is in the same location as the first one (like when drawing rocks)?
Am 25.03.2026 um 15:36 schrieb Rodrigo Severo via Therion <therion@speleo.sk>:
Hi,
I was trying to understand how Therion deals with "line -close ON|OFF|AUTO" and found an expected behaviour for "line -close on".
For the simple file attached (here is a print screen on Mapiah):
<image.png> Here is the current result (again, original file attached, here a simple print screen): <image.png>
And here is want I expected, the new result with PR #741 (https://github.com/therion/therion/pull/741) produces:
<image.png>
The patch I created clearly changes the behaviour of Therion but, I believe, it changes to something more sensible.
Does this change looks like a issue to someone?
Regards,
Rodrigo
<line_close.zip> <line_close-new.pdf> <line_close-current.pdf> _______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
_______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
participants (2)
-
Benedikt Hallinger -
Rodrigo Severo