Therion 5.5.5 + 5a614ef testing - colour map-fg hierarchy
Stacho Most of my datasets checked so far look OK, but there is one that is suspicious, and I am not sure of the proper hierarchy or what it has been in the preceding versions, so it may be OK. What seems to be happening for colour map-fg hierarchy is: 1. ‘lookup’ colours defined in layout override all other map-fg colour specifications 2. ‘Selected’ map colours specified in thconfig override unless there is a matching lookup 3. Explicitly specified map-fg colours are ignored if either of the above are present. I was expecting that number 2 to be top of the list, always, and then the other two dependent on the order called. But it seems never to be the case if there is a lookup, the hierarchy is always as above I think. It might always have been this way, but it seems inconsistent that; a. Selected map colours in thconfig do not always override those defined in layouts (lookups and explicitly specified map-fg), and b. Lookup and explicitly specified map-fg colours do not take their precedence based on order of appearance in layouts. A limited example…. In thconfig: select MegamaniaBeyondWordsPlanMap -color [100 0 0] #ie colour red should override for whole map In layout: colour map-fg map, with a ‘lookup map’ defined Output: Is greyscale as set in a map lookup Change layout to: colour map-fg [97 86 38] # yellow brown Output: Is red as expected, with the select map colour overriding If it has always been this way, then it is not a problem to consider for the Debian release, but maybe later on. Bruce From: Therion <therion-bounces@speleo.sk> On Behalf Of Stacho Mudrak Sent: Thursday, 24 December 2020 09:44 To: List for Therion users <therion@speleo.sk> Subject: Re: [Therion] Therion 5.5.5 bug - statistics missing from header If you will find some bugs or some suspicious behavior, please let us know. And if someone could test the latest version on some larger datasets, it would be great. We would like to have the most stable version of therion in Debian 11 release and there are still some days left until freeze happens. Thanks, S. On Wed, 23 Dec 2020 at 15:07, Benedikt Hallinger <beni@hallinger.org <mailto:beni@hallinger.org> > wrote: Ok wookey, will check that regarding the glx Patch issue then.
Am 23.12.2020 um 14:26 schrieb Wookey <wookey@wookware.org <mailto:wookey@wookware.org> >:
On 2020-12-23 10:42 +0100, Stacho Mudrak wrote:
I am sorry, one bug fixed, another introduced :/ It should be OK in 5a614ef. Windows binaries should be automatically built within half an hour.
And the Debian packages are now built in unstable. They should move into testing in 5 days time.
Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ _______________________________________________ Therion mailing list Therion@speleo.sk <mailto:Therion@speleo.sk> https://mailman.speleo.sk/listinfo/therion
Therion mailing list Therion@speleo.sk <mailto:Therion@speleo.sk> https://mailman.speleo.sk/listinfo/therion
Thanks for finding this out, Bruce. It looks, that it has been this way even before so we will try to solve this issue after Debian freeze to avoid introduction of new bugs. S. On Thu, Dec 24, 2020, 06:05 Bruce Mutton <bruce@tomo.co.nz> wrote:
Stacho
Most of my datasets checked so far look OK, but there is one that is suspicious, and I am not sure of the proper hierarchy or what it has been in the preceding versions, so it may be OK.
What seems to be happening for colour map-fg hierarchy is:
1. ‘lookup’ colours defined in layout override all other map-fg colour specifications 2. ‘Selected’ map colours specified in thconfig override unless there is a matching lookup 3. Explicitly specified map-fg colours are ignored if either of the above are present.
I was expecting that number 2 to be top of the list, always, and then the other two dependent on the order called. But it seems never to be the case if there is a lookup, the hierarchy is always as above I think.
It might always have been this way, but it seems inconsistent that;
1. Selected map colours in thconfig do not always override those defined in layouts (lookups and explicitly specified map-fg), and 2. Lookup and explicitly specified map-fg colours do not take their precedence based on order of appearance in layouts.
A limited example….
In thconfig:
select MegamaniaBeyondWordsPlanMap -color [100 0 0] #ie colour red should override for whole map
In layout:
colour map-fg map, with a ‘lookup map’ defined
Output:
Is greyscale as set in a map lookup
Change layout to:
colour map-fg [97 86 38] # yellow brown
Output:
Is red as expected, with the select map colour overriding
If it has always been this way, then it is not a problem to consider for the Debian release, but maybe later on.
Bruce
*From:* Therion <therion-bounces@speleo.sk> *On Behalf Of *Stacho Mudrak *Sent:* Thursday, 24 December 2020 09:44 *To:* List for Therion users <therion@speleo.sk> *Subject:* Re: [Therion] Therion 5.5.5 bug - statistics missing from header
If you will find some bugs or some suspicious behavior, please let us know. And if someone could test the latest version on some larger datasets, it would be great.
We would like to have the most stable version of therion in Debian 11 release and there are still some days left until freeze happens.
Thanks, S.
On Wed, 23 Dec 2020 at 15:07, Benedikt Hallinger <beni@hallinger.org> wrote:
Ok wookey, will check that regarding the glx Patch issue then.
Am 23.12.2020 um 14:26 schrieb Wookey <wookey@wookware.org>:
On 2020-12-23 10:42 +0100, Stacho Mudrak wrote:
I am sorry, one bug fixed, another introduced :/ It should be OK in 5a614ef. Windows binaries should be automatically built within half an hour.
And the Debian packages are now built in unstable. They should move into testing in 5 days time.
Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ _______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
_______________________________________________ Therion mailing list Therion@speleo.sk https://mailman.speleo.sk/listinfo/therion
participants (2)
-
Bruce Mutton -
Stacho Mudrak