+++ Martin Sluka [2013-12-22 23:26 +0100]:
Exactly after one year! Martin Sluka
Nice! And some of the bugs I have patches for are fixed. Great. A few observations about the source tarball: 1) There is a thTMPDIR in samples/areas/ which I don;t think should be there. 2) I think someone changed their editor settings. Many of the C++ changes have the new lines TAB-indented amongst existing space-indented code, which, at least on my editor, comes out all wrong (and is generally bad practice for exactly this reason). Looks like the editor was set to TAB=2spaces. I'll fix all that up in the debian package and send a patch. 3) output files are shipped in the samples dirs: q-marks/map.xvi survex/create/create.3d survex/ignore/ignore.3d survex/use/use/3d survex/cave.3d I don't think that's really right either, although it doesn't break anything 4) There are a pile of bugs the debian patches fix which remain unfixed in 5.3.12: compiler warnings and code cleanup (mostly unused variables): * (fix-icon-compiler-warnings) * (fix-compiler-warnings.patch) The update to understand survex v8 .3d files (with splays) (update-survex-img-parser-to-v8.patch) Some files missed by the clean target The extensionless files fix (90load-extensionless-files.patch) The fix to avoid segfaulting if the language file is missing (82-nolang-segfault-fix.patch) samples encoding, and clean fixes 'hardening' fix: (hardening-flags-fix.patch) Did you look at some of those and decide not to include them? Mostly I thnk they are uncontroversial. Anywa, I have updated all the patches and will build and test. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
+++ Wookey [2013-12-24 03:41 +0000]:
+++ Martin Sluka [2013-12-22 23:26 +0100]:
Exactly after one year!
A few observations about the source tarball:
3) output files are shipped in the samples dirs: q-marks/map.xvi survex/create/create.3d survex/ignore/ignore.3d survex/use/use/3d survex/cave.3d
Actually the .3ds are supposed to be there - ignore that, (but the xvi isn't) :-)
Anyway, I have updated all the patches and will build and test.
OK. amd64 packages for wheezy (Debian stable) are at: http://wookware.org/software/repo/ Please test them. Do we believe that http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718294 is fixed in 5.3.12? Trying an unstable build next. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
+++ Wookey [2013-12-24 04:21 +0000]:
OK. amd64 packages for wheezy (Debian stable) are at: http://wookware.org/software/repo/
Please test them.
I tested them here and they worked for some basic smoke tests. There seems to be an issue with loading lox files from the 'recently used' menu ('Error reading file'), but it works OK from the filer pointing at the actual file.
Do we believe that http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718294 is fixed in 5.3.12?
I've tried to reproduce this with therion 5.3.10, 5.3.11 and 5.3.12 and have failed. Can anyone else reproduce it, and/or confirm it fixed with 5.3.11 or 5.3.12? Just uploaded 5.3.12-1 to Debian unstable. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
Hello,
I tested them here and they worked for some basic smoke tests. There seems to be an issue with loading lox files from the 'recently used' menu ('Error reading file'), but it works OK from the filer pointing at the actual file.
I build the new verision on debian stable it works fine, I can't reproduce the 'recently used', it works for me.
Do we believe that http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718294 is fixed in 5.3.12?
I updated my Sid and I have this bug with 5.3.12 same as 5.3.11 To reproduce it you have to use an existing th2 file with a link to an existing image, you can open it on stable debian version but on Sid, the background image is not visible and when you try to add an image it crash. :'( C.S. 2013/12/25, Wookey <wookey@wookware.org>:
+++ Wookey [2013-12-24 04:21 +0000]:
OK. amd64 packages for wheezy (Debian stable) are at: http://wookware.org/software/repo/
Please test them.
I tested them here and they worked for some basic smoke tests. There seems to be an issue with loading lox files from the 'recently used' menu ('Error reading file'), but it works OK from the filer pointing at the actual file.
Do we believe that http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718294 is fixed in 5.3.12?
I've tried to reproduce this with therion 5.3.10, 5.3.11 and 5.3.12 and have failed. Can anyone else reproduce it, and/or confirm it fixed with 5.3.11 or 5.3.12?
Just uploaded 5.3.12-1 to Debian unstable.
Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/ _______________________________________________ Therion mailing list Therion@speleo.sk http://mailman.speleo.sk/mailman/listinfo/therion
+++ cawa sorix [2013-12-25 17:25 +0100]:
Do we believe that http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718294 is fixed in 5.3.12?
I updated my Sid and I have this bug with 5.3.12 same as 5.3.11
To reproduce it you have to use an existing th2 file with a link to an existing image, you can open it on stable debian version but on Sid, the background image is not visible and when you try to add an image it crash. :'(
Aha - it hapens on jessie and sid, but not wheezy. OK. I can reproduce now. Cheers Cawa. Something to do with the libtk-img package perhaps, as that's responsible for adding tck/tk png support. It's installed. http://packages.qa.debian.org/libt/libtk-img.html shows that it changed from 1.3 to 1.4 between stale (wheezy) and testing (jessie), which sugests that 1.3 works and 1.4 doesn't. SImply reverting to v1.3 doesn't fix it, but maybe it's need to be rebuilt agianst the corresponding headers too? So trying to insert background in a new (empty) .th2 file gives: ag "command" doesn't match any items tag "command" doesn't match any items while executing "$xth(me,can) lower $xth(me,imgs,$imgx,image) command" (procedure "xth_me_image_insert" line 201) invoked from within "xth_me_image_insert $xth(ctrl,me,images,newposx) $xth(ctrl,me,images,newposy) {} 0 {}" ("uplevel" body line 4) invoked from within "uplevel \#0 $cmd" (procedure "Button::_release" line 23) invoked from within "Button::_release .xth.me.af.ctrl.cf11.f.ic.insp" (command bound to event). Taking a file that should have an image already such as initially doesn't show the background image, but adding a second one makes it appear in the list in the UI twice, and the just-inserted one displays correctly. Closing the file now cuases this error: an't unset "xth(me,imgs,0,name)": no such element in array can't unset "xth(me,imgs,0,name)": no such element in array while executing xth_me_image_destroy_all" (procedure "xth_me_destroy_file" line 13) invoked from within "xth_me_destroy_file" (procedure "xth_me_close_file" line 12) invoked from within "xth_me_close_file" invoked from within ".xth.#xth#me#menu.#xth#me#menu#file invoke active" ("uplevel" body line 1) invoked from within "uplevel #0 [list $w invoke active]" (procedure "tk::MenuInvoke" line 50) invoked from within "tk::MenuInvoke .xth.#xth#me#menu.#xth#me#menu#file 1" (command bound to event) This looks to me like the image file is not 'initialised' somehow until a second one is read in. I don;t have much idea how this works, so will send thisin in the hope that someone who speaks tcl/tk can see what's up. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
+++ Wookey [2013-12-27 01:37 +0000]:
+++ cawa sorix [2013-12-25 17:25 +0100]:
Aha - it hapens on jessie and sid, but not wheezy. OK. I can reproduce now. Cheers Cawa.
Something to do with the libtk-img package perhaps, as that's responsible for adding tck/tk png support. It's installed. http://packages.qa.debian.org/libt/libtk-img.html shows that it changed from 1.3 to 1.4 between stale (wheezy) and testing (jessie), which sugests that 1.3 works and 1.4 doesn't. SImply reverting to v1.3 doesn't fix it, but maybe it's need to be rebuilt agianst the corresponding headers too?
I rebuilt libtk-img 1:1.3-release-12 from stable in unstable and run xtherion against it. It still fails in exactly the same way as with libtk-img 1.4
So trying to insert background in a new (empty) .th2 file gives: tag "command" doesn't match any items while executing "$xth(me,can) lower $xth(me,imgs,$imgx,image) command"
I have spend some time fiddling with this, but as I don;t really understand tcl I'm not getting very far. I beleive that "$xth(me,can)" is the xtherion map-editor canvas 'object'?, and "lower $xth(me,imgs,$imgx,image) " is the image in question. 'command' just seems to e a string not a variable so I don't know what 'command' it is trying to do? Removing 'command' from that line stops the error "tag "command" doesn't match any items", but doesn't change the behaviour. I don't understand why this works OK on stable, but not unstable. Given that libtk-img 1.3 and 1.4 seem to behave exactly the same in this regard, I guess the problem must be something else. Does that 'command' string get passed into libtk-img or processed elsewhere in xtherion? I've tried and failed to find the API spec for the tk-img library to help understand this. There do seem to have been some quite significant changes in the layout and packaging between 1.3 and 1.4, but nominally not in the functionality so far as I can tell. Can someone who understands tcl and libtk-img please give me some clues on how to debug this. cc:ed to the libtk-img maintainer in the hope that he can shed some light. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
Hello Probably imagemagick command line tools is missing? I had a similar problem and installing imagemagick helped to solve it 21.01.2014 22:48, Wookey пишет:
+++ Wookey [2013-12-27 01:37 +0000]:
+++ cawa sorix [2013-12-25 17:25 +0100]: Aha - it hapens on jessie and sid, but not wheezy. OK. I can reproduce now. Cheers Cawa.
Something to do with the libtk-img package perhaps, as that's responsible for adding tck/tk png support. It's installed. http://packages.qa.debian.org/libt/libtk-img.html shows that it changed from 1.3 to 1.4 between stale (wheezy) and testing (jessie), which sugests that 1.3 works and 1.4 doesn't. SImply reverting to v1.3 doesn't fix it, but maybe it's need to be rebuilt agianst the corresponding headers too? I rebuilt libtk-img 1:1.3-release-12 from stable in unstable and run xtherion against it. It still fails in exactly the same way as with libtk-img 1.4
So trying to insert background in a new (empty) .th2 file gives: tag "command" doesn't match any items while executing "$xth(me,can) lower $xth(me,imgs,$imgx,image) command" I have spend some time fiddling with this, but as I don;t really understand tcl I'm not getting very far.
I beleive that "$xth(me,can)" is the xtherion map-editor canvas 'object'?, and "lower $xth(me,imgs,$imgx,image) " is the image in question. 'command' just seems to e a string not a variable so I don't know what 'command' it is trying to do?
Removing 'command' from that line stops the error "tag "command" doesn't match any items", but doesn't change the behaviour.
I don't understand why this works OK on stable, but not unstable. Given that libtk-img 1.3 and 1.4 seem to behave exactly the same in this regard, I guess the problem must be something else. Does that 'command' string get passed into libtk-img or processed elsewhere in xtherion?
I've tried and failed to find the API spec for the tk-img library to help understand this.
There do seem to have been some quite significant changes in the layout and packaging between 1.3 and 1.4, but nominally not in the functionality so far as I can tell.
Can someone who understands tcl and libtk-img please give me some clues on how to debug this.
cc:ed to the libtk-img maintainer in the hope that he can shed some light.
Wookey
+++ Vasily Vl. Suhachev [2014-01-21 23:14 +0800]:
Hello
Probably imagemagick command line tools is missing?
I had a similar problem and installing imagemagick helped to solve it
Thanks for the suggestion, but no, imagemagick is installed, so that's not it. And I don't think either therion or libtk-img should need this, not for displaying background images, anyway. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
+++ Wookey [2013-12-24 03:41 +0000]:
2) I think someone changed their editor settings. Many of the C++ changes have the new lines TAB-indented amongst existing space-indented code, which, at least on my editor, comes out all wrong (and is generally bad practice for exactly this reason). Looks like the editor was set to TAB=2spaces. I'll fix all that up in the debian package and send a patch.
Patch to fix up all the 'TAB should be 2 spaces' untidiness introduced in 5.3.12. attached Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
participants (4)
-
cawa sorix -
Martin Sluka -
Vasily Vl. Suhachev -
Wookey