Hi therioneers, Attached are five patches: therion-document-missing-cs.patch Not all the coordinate systems which therion understands are listed in the manual - this patch adds the missing ones, though I don't know what JTSK03, IJTSK03 or S-MERC are, so please fill in where the '?' are. therion-fix-init-order.patch In C++, class members are initialised in the order declared in the class, and it's clearer if the order of the initialiser list matches the order the members are actually initialised in. Some compilers will issue a warning if they don't match. therion-fix-memory-leak.patch Free the memory proj_init_plus() allocates. therion-fix-typo.patch Fix a typo. therion-remove-unsigned-less-than-zero-checks.patch These checks can never be true, since size_t is unsigned. I've removed them in the patch, though perhaps these checks were intended to be ==0 rather than <0? Cheers, Olly
+++ Olly Betts [2014-06-07 06:43 +0100]:
Hi therioneers,
Attached are five patches:
...
therion-fix-init-order.patch
In C++, class members are initialised in the order declared in the class, and it's clearer if the order of the initialiser list matches the order the members are actually initialised in. Some compilers will issue a warning if they don't match.
This is already applied in the existing package as part of the "fix-compiler-warnings.patch" you previously supplied. I've included the others ready for the next upload. Cheers. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
On Sat, Jun 07, 2014 at 06:43:09AM +0100, Olly Betts wrote:
therion-document-missing-cs.patch
Not all the coordinate systems which therion understands are listed in the manual - this patch adds the missing ones, though I don't know what JTSK03, IJTSK03 or S-MERC are, so please fill in where the '?' are.
It appears "S-MERC" is the spherical mercator projection often known as "Web Mercator", as used by various online mapping sites (e.g. OpenStreetMap, Google maps, Bing maps). Cheers, Olly
participants (3)
-
Martin Sluka -
Olly Betts -
Wookey